Return to Video

vimeo.com/.../330122657

  • 0:03 - 0:06
    Hey there this is Mark, founder of modmore
  • 0:06 - 0:10
    and in this video I'm going to quickly show how you can help with editing the new MODX documentation
  • 0:11 - 0:14
    First things first, this is the documentation
  • 0:14 - 0:14
    I'm referring to
  • 0:15 - 0:17
    which is currently available on docs.modx.org
  • 0:18 - 0:22
    which is different from the version that
    runs on docs.modx.com
  • 0:23 - 0:27
    it's basically a community project we've
    been working on
  • 0:27 - 0:30
    to convert the documentation to the
    markdown format
  • 0:30 - 0:34
    and hosting those on github to allow
    open and transparent collaboration
  • 0:34 - 0:36
    to make it better
  • 0:36 - 0:41
    it's still under active development, so
    if you watch this later you may notice
    some things have changed
  • 0:41 - 0:43
    in the design or overall structure
  • 0:43 - 0:46
    but this is basically what we're looking
    at today
  • 0:48 - 0:52
    so let's see how this works, how we can
    make a change to this documentation
  • 0:53 - 0:56
    let's say we were browsing the extras
  • 0:56 - 0:59
    and we were looking at the
    addHeaderfiles snippet
  • 1:00 - 1:04
    and we noticed that this table here
    doesn't look right
  • 1:05 - 1:08
    the first column is missing, it seems to
    have shifted
  • 1:08 - 1:11
    and this is actually a result of the
    conversion which happened
  • 1:11 - 1:15
    on some pages which we can
    quite easily fix
  • 1:16 - 1:24
    to do that we'll find the "Edit this page"
    link which is located both here in the
    title as well as in the footer
  • 1:24 - 1:27
    and this will open a new page on github
  • 1:29 - 1:34
    You do need a github account, which is
    free if you don't already have one
  • 1:34 - 1:38
    and I'll just login as my test account
  • 1:38 - 1:42
    just so it's the same way it will be for
    you the first time you edit something
  • 1:44 - 1:48
    So the first thing it asks me for is to
    fork the repository.
  • 1:48 - 1:52
    If you're not familiar with how git or git
    flow and all that works, no worries.
  • 1:52 - 1:58
    Just click the green button which
    will basically make a copy of the
  • 1:58 - 2:01
    official documentation that you can make
    changes to directly.
  • 2:02 - 2:07
    The official version, which is under the
    modxorg name, not everyone can change
  • 2:07 - 2:12
    that directly, so forking is the way to
    start making changes.
  • 2:13 - 2:15
    So I'll fork it.
  • 2:15 - 2:18
    Which will land us in the edit view.
  • 2:19 - 2:25
    It immediately sends us to the right page,
    the addHeaderfiles extra.
  • 2:26 - 2:30
    We can now look at what happened with
    that table.
  • 2:30 - 2:34
    So this is roughly how a table is managed
    in markdown.
  • 2:35 - 2:37
    There are these pipe symbols (|)
  • 2:37 - 2:39
    and then there's content in the cell
  • 2:39 - 2:41
    another pipe symbol, more content
  • 2:43 - 2:46
    this is basically the separation between
    the header and the body of a table
  • 2:47 - 2:48
    and then there's the rest
  • 2:49 - 2:53
    so the problem here is actually,
    may be a bit hard to see
  • 2:53 - 2:56
    but there's a space before each line
    of the table
  • 2:57 - 2:59
    that's causing it to not get rendered
    properly
  • 2:59 - 3:03
    so what i'll do is, I'll just select
    all the lines and do a shift-tab
  • 3:04 - 3:08
    which puts everything nicely in the
    right place
  • 3:09 - 3:12
    and while we're at it, we could also make
    other changes
  • 3:12 - 3:14
    I mean we could check the content, is it
    written properly?
  • 3:14 - 3:17
    maybe there are some formatting issues?
  • 3:18 - 3:23
    I guess there's some code here that should
    be wrapped in these little quotes
  • 3:23 - 3:26
    to make sure they're formatted as code
    as well
  • 3:27 - 3:31
    so basically you can edit the entire page
    content just from this view
  • 3:33 - 3:36
    When you're happy with this, you need to
    save the changes.
  • 3:36 - 3:38
    That's called a "commit" in git terms.
  • 3:38 - 3:42
    But you can do that just from the bottom
    here where it says "Propose file change"
  • 3:43 - 3:51
    So we can say "fix formatting issues on
    addHeaderFiles page"
  • 3:52 - 3:55
    You can add an additional description here
    but that's not necessary
  • 3:55 - 3:58
    We'll click the green button to propose
    the file change
  • 4:01 - 4:05
    That sends us into a view where we can
    compare the changes we made
  • 4:05 - 4:07
    to the official version.
  • 4:08 - 4:14
    So we can see here the base repository
    is Docs under modxorg, and ours is
  • 4:14 - 4:18
    Mark-H2 with a certain branch name
  • 4:20 - 4:24
    So we can see what we did, removed some
    spaces and added some formatting
  • 4:24 - 4:25
    at the bottom
  • 4:29 - 4:32
    Now the next step is to click "Create Pull
    Request"
  • 4:33 - 4:36
    So as we are working in our own fork,
    in our own copy
  • 4:36 - 4:41
    the pull request is basically where you
    ask maintainers of the official version
  • 4:41 - 4:46
    like "this is the change I made, can you
    please include it in the official version"
  • 4:47 - 4:53
    So we can just click that button which
    will give us a new form to fill out
  • 4:54 - 4:58
    basically the information needed by the
    maintainers to see if it's a good change
  • 4:58 - 4:59
    or not
  • 5:00 - 5:03
    So we can describe this as
  • 5:05 - 5:13
    "Some formatting issues on addHeaderFIles
    Page causing table to not render properly"
  • 5:18 - 5:21
    which affects version 2.x
  • 5:21 - 5:25
    cause we do have different versions in
    the documentation now
  • 5:26 - 5:30
    and we don't have a relevant issue
    for this one
  • 5:32 - 5:34
    So this is basically what we need
    to fill out
  • 5:36 - 5:41
    At this point the maintainers of the
    project get a notification
  • 5:41 - 5:44
    that there's a new change
  • 5:44 - 5:47
    I can actually show you what that
    looks like
  • 5:48 - 5:51
    when I'm bringing my other screen
  • 5:53 - 5:57
    So this is the same repository except now
    I'm logged in as my main user account
  • 5:58 - 6:02
    and I can see that Mark-H2, who is a
    first-time contributor
  • 6:02 - 6:05
    has suggested some changes
  • 6:05 - 6:08
    I can review them through the files tab
  • 6:09 - 6:13
    and when I say "okay this is a good
    change, something we really need"
  • 6:13 - 6:16
    I can merge it from here.
  • 6:18 - 6:23
    So I'll confirm that and at this point the
    change is made in the official version
  • 6:23 - 6:28
    What happens next is that the change needs
    to be deployed which is semi-automatic
  • 6:28 - 6:30
    it will be fully automatic soon
  • 6:31 - 6:34
    So it looks like it's completed (the deployment)
  • 6:36 - 6:39
    so now I can go back to my
    documentation
  • 6:40 - 6:42
    and if I refresh the page
  • 6:44 - 6:48
    you will see that it is now a little
    bit better
  • 6:48 - 6:51
    there are still some formatting issues
    here where it's breaking up the line
  • 6:51 - 6:54
    but that's a design thing that needs to
    be addressed differently
  • 6:55 - 6:59
    you can see that the other change we made
    here, properly marking these as code
  • 7:00 - 7:02
    did apply properly
  • 7:05 - 7:09
    So that's basically the process for
    editing the documentation.
  • 7:10 - 7:15
    You can go to anywhere on this website
    to find the edit page link
  • 7:15 - 7:17
    to get directly to the right page
    on GitHub
  • 7:18 - 7:22
    If you go to Github you can also browse
    the documentation from there
  • 7:22 - 7:26
    You can see we currently have English,
    Dutch and Russian versions
  • 7:27 - 7:29
    English is the source version
  • 7:29 - 7:32
    the others are translations, and
    especially Russian is coming along nicely
  • 7:34 - 7:39
    We can just browse around here and say
    okay maybe I want to change something
  • 7:39 - 7:42
    in... I don't know.. the api reference
  • 7:43 - 7:45
    which is not a very interesting page
  • 7:46 - 7:49
    but then there's the edit link right here
    at the top
  • 7:50 - 7:53
    that will again bring us to the same
    page we saw before
  • 7:53 - 7:57
    where we can edit the page, edit the
    source of the page, and propose
  • 7:57 - 8:00
    the change at the bottom which will
    send us into the pull request
  • 8:00 - 8:03
    for the process of getting it merged
    into the official version
  • 8:04 - 8:08
    I do want to encourage everybody to
    just see if you can help out with this
  • 8:09 - 8:13
    there are a couple of issues logged
    on github as well
  • 8:13 - 8:16
    with things that have been identified
    as needing to be fixed
  • 8:17 - 8:18
    Thanks for watching
  • 8:18 - 8:23
    I hope this shows how you can help out,
    how you can contribute to the new docs
  • 8:23 - 8:26
    without needing to know all about how
    git works
  • 8:26 - 8:31
    just the basics of changing a file and
    submitting it to be included
Title:
vimeo.com/.../330122657
Video Language:
English
Duration:
08:32

English subtitles

Revisions