Return to Video

Updated - Updating a Pull Request

  • 0:00 - 0:04
    I just got an email letting me know
    that Sarah commented on my pull request.
  • 0:04 - 0:06
    She says that I misspelled canola.
  • 0:06 - 0:08
    Well, I'll go take a look.
  • 0:09 - 0:10
    Canols oil.
  • 0:10 - 0:12
    Yeah that's not right.
  • 0:12 - 0:13
    I'll go ahead and fix that.
  • 0:13 - 0:15
    And I'll commit my fix.
  • 0:15 - 0:19
    Now since I want this change to be
    visible on GitHub also I'll push.
  • 0:19 - 0:23
    Pushing the branch automatically
    updates the pull request on GitHub.
  • 0:23 - 0:26
    Underneath Sarah's comment about
    my misspelling you can see my
  • 0:26 - 0:28
    commit fixing the typo.
  • 0:28 - 0:31
    Also, if I look at the commits
    I can see there are two now.
  • 0:31 - 0:35
    And if I look at the files changed
    I can see the correct spelling.
  • 0:35 - 0:37
    Now I'd like you to
    follow the same steps and
  • 0:37 - 0:39
    make a pull request on your own.
  • 0:39 - 0:41
    First, create a new branch
    called different-oil,
  • 0:41 - 0:44
    then make a different commit
    on the different-oil branch,
  • 0:44 - 0:47
    to use canola oil instead of
    vegetable oil like I did.
  • 0:47 - 0:50
    If you want, you can make a typo
    on purpose but that's optional.
  • 0:50 - 0:53
    Then push your different-oil
    branch to your fork on GitHub and
  • 0:53 - 0:55
    create a pull request.
  • 0:55 - 0:58
    Make sure to change the base to
    the master branch of your repository and
  • 0:58 - 1:00
    not Larry's repository.
  • 1:00 - 1:05
    If you made a typo earlier, then make
    another commit to fix the typo and
  • 1:05 - 1:06
    update the pull request.
  • 1:06 - 1:09
    Finally, paste the link to
    your pull request in this box.
  • 1:09 - 1:13
    You can find a link to your pull request
    by viewing your repository on GitHub,
  • 1:13 - 1:17
    scrolling over to the right, and
    looking at the list of pull requests.
  • 1:17 - 1:22
    Then click on your pull requests,
    and copy this URL from the URL bar.
  • 1:22 - 1:25
    Finally, make sure you don't
    merge the pull request yet.
  • 1:25 - 1:27
    If you do,
    then a later exercise won't work
Title:
Updated - Updating a Pull Request
Description:

04-26 Updating a Pull Request

more » « less
Video Language:
English
Team:
Udacity
Project:
UD775 - How to Use Git and GitHub
Duration:
01:30

English subtitles

Revisions Compare revisions